Let's switch the calls to the log crate at the same time, then?

Yeh, there's a reason it's a draft ^^

Don't know when I'll continue though.

Codecov Report

Attention: 88 lines in your changes are missing coverage. Please review.

Comparison is base (daad1fc) 3.63% compared to head (ce4ba97) 3.60%.

❗ Current head ce4ba97 differs from pull request most recent head bac7984. Consider uploading reports for the commit bac7984 to get more accurate results

@@           Coverage Diff            @@
##            main    #255      +/-   ##
========================================
- Coverage   3.63%   3.60%   -0.04%     
========================================
  Files         37      37              
  Lines       2832    2860      +28     
========================================
  Hits         103     103              
- Misses      2729    2757      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

A cleaner trace for Envelopes would be beneficial:

2024-01-06 14:23:13 [INFO] decrypt; self=ServiceCipher { protocol_store: "...", csprng: "...", trust_root: "...", local_uuid: 9bad1xx, local_device_id: 1 } envelope=Envelope { r#type: Some(UnidentifiedSender), source_service_id: None, source_device: None, destination_service_id: Some("9bad"), timestamp: Some(170455xxx), content: Some([17, 10, 33, **LOADS MORE**, ...]), server_guid: Some("4d46a6"), server_timestamp: Some(17045509xxx), urgent: Some(false), story: Some(false), reporting_token: None }

This is looking pretty neat imo!

A cleaner trace for Envelopes would be beneficial:

2024-01-06 14:23:13 [INFO] decrypt; self=ServiceCipher { protocol_store: "...", csprng: "...", trust_root: "...", local_uuid: 9bad1xx, local_device_id: 1 } envelope=Envelope { r#type: Some(UnidentifiedSender), source_service_id: None, source_device: None, destination_service_id: Some("9bad"), timestamp: Some(170455xxx), content: Some([17, 10, 33, **LOADS MORE**, ...]), server_guid: Some("4d46a6"), server_timestamp: Some(17045509xxx), urgent: Some(false), story: Some(false), reporting_token: None }

Most definitely, let's impl tracing::Value for it!

Most definitely, let's impl tracing::Value for it!

Turns out that is pretty difficult :'-)

One needs to implement valuable::Valuable (Value itself is Sealed), but Valuable is quite the involved visitor pattern.

I'm pulling spans over await points, and I shouldn't be doing that in libsignal-service-actix/src/push_service.rs. Needs fixing.

I'm pulling spans over await points, and I shouldn't be doing that in libsignal-service-actix/src/push_service.rs. Needs fixing.

I fixed most of these, let's get this pulled in! Looks rather pretty imo :)